fix(core): Enable save method for ChatPromptTemplate by removing NotImplementedError override
#32997
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Issue #32637 where ChatPromptTemplate's save method was raising NotImplementedError instead of inheriting the working implementation from BasePromptTemplate.
Issue
The ChatPromptTemplate class was overriding the parent class's working
savemethod with a stub that just raisedNotImplementedError. This prevented users from saving ChatPromptTemplate instances to files, even though the parent class BasePromptTemplate has a fully functional save implementation.Root Cause
In
src/transformers/processing_utils.pyline 1303, there was an override:Solution
The fix removes this override, allowing ChatPromptTemplate to inherit the working
savemethod from BasePromptTemplate. This enables users to save ChatPromptTemplate instances to JSON/YAML files as expected.Testing
Added a test case that verifies:
Impact
This is a backward-compatible bug fix that restores expected functionality for ChatPromptTemplate serialization. Users can now save and load ChatPromptTemplate instances as documented, which is important for persisting prompt configurations.
Fixes #32637